fix(cli): respect --json flag on lint error paths#125
Closed
miguel-heygen wants to merge 1 commit into03-29-fix_cli_suppress_ansi_escape_codes_in_non-tty_progress_outputfrom
Conversation
miguel-heygen
force-pushed
the
03-29-fix_cli_respect_--json_flag_on_lint_error_paths
branch
from
29959e8 to
f0955b7
Compare
miguel-heygen
force-pushed
the
03-29-fix_cli_suppress_ansi_escape_codes_in_non-tty_progress_output
branch
from
788be01 to
78fd863
Compare
This was referenced Mar 29, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
When lint encountered an error (e.g., invalid directory), it output
plain text even with --json, breaking JSON parsing pipelines for
agents. Now wraps the entire lint command in try-catch that emits
JSON errors when --json is set.
Reproducer:
npx hyperframes lint --json /nonexistent/path
# Was: plain text "Not a directory: /nonexistent/path"
# Now: {"ok": false, "error": "Not a directory: /nonexistent/path", ...}
miguel-heygen
force-pushed
the
03-29-fix_cli_respect_--json_flag_on_lint_error_paths
branch
from
f0955b7 to
919e4c2
Compare
miguel-heygen
force-pushed
the
03-29-fix_cli_suppress_ansi_escape_codes_in_non-tty_progress_output
branch
from
78fd863 to
0b2576b
Compare
This was referenced Mar 29, 2026
Closed
Collaborator
Author
|
Consolidated into fix/lint-improvements. |
miguel-heygen
deleted the
03-29-fix_cli_respect_--json_flag_on_lint_error_paths
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack
Summary
lint --jsonencountered an error (e.g., invalid directory), it output plain text instead of JSON, breaking agent JSON parsing pipelinesresolveProject()threw before the JSON output logic was reachedrun()body in try-catch that emits JSON errors when--jsonis setReproducer
Stack
4/8 — Depends on #124
🤖 Generated with Claude Code